nicolas-steenhout / main

For my main site - jekyll and gh pages
MIT License
0 stars 2 forks source link

Contrast - global #87

Closed vavroom closed 1 week ago

vavroom commented 3 weeks ago

◦ Global - Might be fixed with your upcoming style edits, but in Safari, there’s very poor contrast in light mode and some poor contrast in dark mode. I think some of the backgrounds haven’t loaded? Tried on multiple devices. Issues within the header and footer, link contrast, etc. Could be a problem with inheritance in the CSS?

digilou commented 1 week ago

@vavroom Is this still an issue? If so, do you have a screenshot for this? Is it just Safari? What version?

vavroom commented 1 week ago

Cannot replicate. Did not get any screenshots from Alicia. Closing as "can't fix" because I don't think it's an issue.

digilou commented 1 week ago

@vavroom It may be an issue. What I'm wondering is Safari versioning, and if I'll need a fallback for light-dark. It's pretty new, but does work for all the newest versions of major browsers. Which is why I was so excited about it. Definitely won't work for IE6... ;)