Close Button does nothing

nicolas-t / Chocolat

Chocolat : the lightbox so cool horses use it :horse:

http://chocolat.insipi.de

GNU General Public License v3.0

1.69k stars 169 forks source link

Close Button does nothing #100

Closed NorlanWaters closed 5 years ago

NorlanWaters commented 5 years ago

Hi Nicolas, first, thank you a lot for this awesome plugin!

I have one tiny problem with the close button on the overly. It's there, it triggers the pointer but it's doing nothing onclick. What could be the issue? http://martinschneider-art.de/category/ikonen/ (klick on thumb)

nicolas-t commented 5 years ago

Hello !

Congrats on the 100th issue !

In your chocolat javascript file a line is missing : http://martinschneider-art.de/wp-content/themes/martin-schneider/js/jquery.chocolat.js?ver=5.1.1 line 491 you have :

$([this.elems.overlay[0], this.elems.close[0]])
    .off('click.chocolat')
    .on('click.chocolat', function() {

});

instead of : https://github.com/nicolas-t/Chocolat/blob/ab742f997720cb0b11a9ffc892d50b3d8de46414/dist/js/jquery.chocolat.js#L464-L468

NorlanWaters commented 5 years ago

Worked! Thanks Nicolas! You're the best!