nicolas-t / Chocolat

Chocolat : the lightbox so cool horses use it :horse:
http://chocolat.insipi.de
GNU General Public License v3.0
1.69k stars 169 forks source link

Chocolat not working with IE11 #130

Closed PhucNguyen1501 closed 2 years ago

PhucNguyen1501 commented 2 years ago

Hey,

I've been using Chocolat and enjoying it so far. Recently I encountered an issue with IE11 throwing a syntax error in the chocolat.js: Line 13, Column 35 as shown below:

Screen Shot 2021-10-15 at 3 25 32 pm

I believe this is because IE11 does not support direct arrow function (as per ES6). Can you investigate this?

Cheers

nicolas-t commented 2 years ago

Hello,

I don't have access to IE11. Can you try installing chocolat@1.0.5-beta.0 ?

If you use the classic import described here be sure to use the js files in the ./dist directory (and not ./src)

Thanks for your help

PhucNguyen1501 commented 2 years ago

Hello,

I don't have access to IE11. Can you try installing chocolat@1.0.5-beta.0 ?

If you use the classic import described here be sure to use the js files in the ./dist directory (and not ./src)

Thanks for your help

Hi Nicolas,

Thanks so much for such a prompt reply. I'm using the classic import. I've tried the most recent chocolat.js in the ./dist. Now, I've encountered another error which you can find below:

Screen Shot 2021-10-18 at 4 08 56 pm

Apparently ie11 does not support assign() for Objects?

Thanks in advance!

nicolas-t commented 2 years ago

Hello,

This error is related to jQuery, not Chocolat. Since version 1 Chocolat doesn't rely on jQuery anymore.

nicolas-t commented 2 years ago

Closing. Feel free to reopen if you need any help.

PhucNguyen1501 commented 2 years ago

Hi,

I am still having issue. If you have a closer look at the second line in the above screenshot, it says the error occurred also in the chocolat.js file (line 795, column 5).

Please reopen the issue in the meantime, as I cannot reopen myself because I'm not a collaborator.

Cheers!

nicolas-t commented 2 years ago

Hello,

I added polyfills and now it should work on IE11 with this release: 1.0.5-beta.2

PhucNguyen1501 commented 2 years ago

Hello,

I added polyfills and now it should work on IE11 with this release: 1.0.5-beta.2

Hi Nicolas,

It works fine with IE11 now. Thanks for your help thus far.

Cheers!