search

nicolasbeauvais / vue-social-sharing

A renderless Vue.js component for sharing links to social networks, compatible with SSR
https://nicolasbeauvais.github.io/vue-social-sharing/
MIT License
1.39k stars 196 forks source link

When click share via LINE, there are errors keep appearing until popup closed #343

Open tommy9690 opened 1 year ago

tommy9690 commented 1 year ago

Steps to reproduce

  1. Click on the share Line button, you see popup window
  2. Check the original window without closing the popup, inspect the console and following error keep appearing. Screenshot 2023-05-31 at 12 09 52 PM
stale[bot] commented 11 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

edwh commented 10 months ago

I think the attempt in the library to use window.close() is a bug; from what I can see, it won't work when the child window is on a different domain, which will usually be the case.

A consequence of this is that the buttons don't work when you click for the second time. One way to handle this is to use @open to trigger a re-render of the buttons by changing the key.

The error then occurs, but it's benign and can be ignored (e.g. in Sentry).

kokoforbes commented 8 months ago

@tommy9690 I am having the same issue, where you able to fix that?