nicolasberube / Arzette_Randomizer

Randomizer modification for Arzette: The Jewel of Faramore.
2 stars 1 forks source link

Missing parens make Beach Candle (Cave) show up in logic when you might not be able to get it #1

Closed JillKatze closed 1 month ago

JillKatze commented 1 month ago

I got stuck in an unwinnable state because Beach Candle (Cave) was behind a blue magic wall (flute walls got shuffled to blue) and the item behind the wall gated the path to blue magic.

Looking at the check here, it looks like it's because state.has("Griffin Boots") or state.has("Winged Belt") needs to be in parens here: https://github.com/nicolasberube/Arzette_Randomizer/blob/ba0b7a516de4a5c1e1765f82a0cc4e068a624a03/ArzetteRandomizer.py#L1028

I was missing blue magic but I had the griffin boots and winged belt so that check equated to False and True or True which evaluates to True. False and (True or True) would have correctly evaluated to False.

Version: 1.5.0 Settings:

level_order: "faramore"
barrier_types: true
item_pool:
  npc: true
  bags: true
  keys: true
  hills_key: false
  candles: true
  coins: true
  plants: true
  rocks: true
  upgrades: true
  life_ups: true
  bonus_scrolls: true
  bonus_rewards: true
  race_rewards: true
  beacons: true
  jewels: true
  trading_sequence: "included"
logic:
  tricky_jumps: false
  no_lantern: false
  damage_boost: false
spoiler: true
seed: 708823512
JillKatze commented 1 month ago

Is that... a github spambot on a hacked account? If anyone else sees the comment between this one and my original post before it hopefully gets deleted, don't click that link lol

nicolasberube commented 1 month ago

Should be fixed with release 1.6.0. Thank you so much for the bug report <3