nicolasbrailo / PianOli

Android baby game
GNU General Public License v3.0
59 stars 18 forks source link

New translation: Dutch / Nederlands 🇳🇱 #61

Closed juleskers closed 1 year ago

juleskers commented 1 year ago

I've finally gotten my IntelliJ set up in a way that I can compile and run(emulator only) Android :tada:

First order of business: Dutch translation.

As is my habit, a gazillion small and less-small cleanups first.
I've separated those out into small commits, for easier review and not-merging if so desired.

Please let me know what you think!

settings NL song selection NL

pserwylo commented 1 year ago

Looks awesome, thanks @juleskers. A couple of thoughts (but no show stoppers, definitely merging this):

As a general rule, I wouldn't worry about copying comments or reorganising the other translations. Most translation systems treat them as kind of a machine-readable file. For example, Weblate or even the Android Studio string editor have their own UI's which are typically based on the source translation.

Indeed - I should really setup for this project - the F-Droid community of users is absolutely wonderful at translating free and open source software. @nicolasbrailo - happy to setup Weblate integration if you would like, so that more people can easily translate it. If you want that, I can either give you some pointers on what you'd need to do to setup Weblate for continuous translation, or if you grant me admin here, I can set it up if you prefer. Happy either way.

(@nicolasbrailo - why I have your attention - @juleskers is submitting some wonderful work here and engaging in the tracker in a great way - @juleskers - would you like to, and @nicolasbrailo - would you be open to adding them to the team in some way here? No obligations @juleskers, just nice to have people in the community involved in being there in case the odd maintenance task comes up.

pserwylo commented 1 year ago

@juleskers - would you be able to find some time to also translate the files in fastlane for Dutch? Not the changelogs - they are not useful because old changelogs are not available in Google Play or in F-Droid, however the short and full description are super helpful to be translated.

juleskers commented 1 year ago

Merged 🎉

As for your comments:

nicolasbrailo commented 1 year ago

@pserwylo aren't you an admin already? Happy to add you as one if not, and @juleskers too. Seems I need my 2fa device, which I don't have with me right now, so it may take a bit until I get to it :)