search

nicolasbrailo / PianOli

Android baby game
GNU General Public License v3.0
59 stars 18 forks source link

Attempt to fix common crash with pinned mode when not in foreground. #71

Closed pserwylo closed 11 months ago

pserwylo commented 12 months ago

When quitting, we accidentally returned to the start and launched the main app again, instead of quitting.

Not sure if it actually fixes #65, but perhaps it has a shot at addressing it. At the least, it fixes a weird behaviour that is worth fixing:

weird-lock-behaviour.webm

juleskers commented 11 months ago

I'll be honest, what you've written looks sensible, but Android Lifecycles are so far beyond me at the moment that I have no idea where to start thinking about this, nor really how to test if this is an improvement..

There's so many subtleties going on, that I'm worried we're making things accidentally worse.