Setting up weblate

[pserwylo]

While setting up Weblate for this project (https://hosted.weblate.org/projects/pianoli/), noticed a couple of things needing tidying:

• Hard coded preferences string.
• Old config screenshot with outdated translation.

This also updates the README to link to Weblate for translations.

[juleskers]

Looks good! I particularly like how easy Weblate makes it on the project, and how you got rid of the HTML-tags (that bothered me already when doing Dutch+German).

Approved from me, and I'll gladly merge this, but want to give @nicolasbrailo a chance to speak too (especially before doing my first merge in this repo).

I'm a bit surprised that the CI job didn't trigger here.. I suppose that is because it comes from your personal repo? (Where I see the job did run; I wonder why it's not linked here...) That's probably something we should figure out too.. Running the tests when someone contributes from a fork is somewhat the entire point of that job :frowning:

[nicolasbrailo]

@pserwylo sent a few translations to see what happens, I guess someone needs to approve them in weblate and then we'll get a PR here? That's amazing, thanks for setting this up!

[pserwylo]

Depends how we want it to work. We can do PRs, but I prefer automatically pushing to master from weblate.

Two things required for more automation:

• Add the webhook to GitHub, so weblate will automatically be notified each time new updates are made to the repo (https://docs.weblate.org/en/latest/admin/continuous.html#github-setup)

• Allow the weblate bot user access to commit to the repo (alternatively - you can opt for other approaches such as manually pulling changes from weblate as we see fit, or asking the weblate bot to open pull requests, but in my experience we don't have the skills to vet individual translations anyway, so PRs are at best tick-and-flick and we may as well fully automate by allowing direct pushing to the repo). This is done by granting the https://github.com/weblate user write access to the repo.

Right now, without either, we see the following in Weblate:

Note the outgoing and incoming commits. Webhooks automate incoming (from GitHub to Weblate) commits. Adding bot permissions automate the outgoing (from Weblate to GitHub) commits.

[nicolasbrailo]

Just added the webhook + access for weblate bot - let's see if it works!

[pserwylo]

Thanks. Will go and iron out the kinks then report back here.

A bit out of sync, causing conflicts. Will fix manually then ask Weblate to update again.

[pserwylo]

Manually fixed weblate repo conflicts with #81, which seemed to put things in order. I've accepted your suggestions (typically people don't make "suggestions" as much as they actually make the change to the translation directly - though suggestions are a perfectly valid way to do this). Accepting those has done the following:

Set the repo in weblate to have "3 pending changes". This means three string changes have been made, and at some point in the coming minutes/hours it will commit those to the local repo in Weblate. Once that is done, it will have "1 outgoing commit". At that point, it may or may not push directly to master. I think it may wait more minutes/hours before doing that, so it has the opportunity to push multiple commits at once if desired.

Lets wait and see, it should all be ready to go. Will comment back here when I see things happen on the Weblate end.

[pserwylo]

All seems to be in order. We are indeed receiving commits from Weblate automatically. I'll just randomly cut new releases when/if new translations come in. The more releases, the more often we appear at the top of the F-Droid list, and the more people come to translate. It is a wonderful cycle of community translations :)

For those interested, I chased it up, and the current settings (which I'll leave as is) are that after 24 hours of inactivity, Weblate will push commits to here. There are other times it pushes instantly, such as when a translation is marked as complete, or when a new translation is added.

[juleskers]

Thanks Peter!

By the way, the JulesKers that translated on Weblate is also me (since you asked for our accounts there)