nicolasbrailo / PianOli

Android baby game
GNU General Public License v3.0
59 stars 18 forks source link

Holiday hacking reviews #87

Closed juleskers closed 10 months ago

juleskers commented 10 months ago

Since I'm a perfectionist, and actually already debated some of @pserwylo 's nitpicks with myself:
improvements as discussed in #83 and #84

It feels a bit inconsistent to make stronger null-checks on Piano.addListener(), but remove them in AppConfigTrigger. Still, I think this is at least per-class-consistent. The overall null-checking strategy of the App will probably tend to "more strict" as I work my way "outwards" during my refactorings (what, you thought I was done :stuck_out_tongue: :angel: )