Support for iOS8 - Githubissues

nicolaschengdev / WYPopoverController

WYPopoverController is for the presentation of content in popover on iPhone / iPad devices. Very customizable.

Other

1.94k stars 370 forks source link

Support for iOS8 #130

Open shvekiasaf opened 10 years ago

shvekiasaf commented 10 years ago

Do you plan to support iOS 8 soon? There is an issue with changing orientations, it doesn't work well.

Thank you.

sammcewan commented 10 years ago

I am actively working on fixing this here. Hoping to get it resolved next week. https://github.com/sammcewan/WYPopoverController/tree/fix-iOS8-orientation-handling

shvekiasaf commented 10 years ago

Thanks!

sammcewan commented 10 years ago

FYI for anyone viewing this the above PR resolves key issues mainly relating to changes in orientation handling in iOS8. This fixed this library for me. Would love to get this merged but activity on this repo has been dead for months.

gpdawson commented 10 years ago

Thanks Sam - this is a really useful control - your work to update it is appreciated by me, at least.

vitalys commented 10 years ago

@sammcewan, thanks for your fix, but there is a serious bug. You add observer for preferredContentSize value on every call of presentPopoverFromRect, but it can be called to move popover, without dismissing. As result you can add observer more than one time and remove it only once in dismissPopoverAnimated. Additional flag like isListeningNotifications is required to avoid this.

sammcewan commented 10 years ago

@vitalys Thanks for raising. Please feel free to get a fix into this iOS8 support branch.

vitalys commented 10 years ago

@sammcewan, I've just created a pull request with my fix.

pablogeek commented 10 years ago

Please ios8 is comming , I hope to get the library fixed in a few days ;)

sammcewan commented 10 years ago

Use the branch in the pull request we've been working on @pablogeek. I doubt we'll see it accepted any time soon.

pablogeek commented 10 years ago

I'm using cocoapods, can I use the branch in the pull request on cocoapods?

ashavit commented 10 years ago

@pablogeek You can use this line for the podfile: pod 'WYPopoverController' ,:git => 'https://github.com/sammcewan/WYPopoverController.git', :branch => 'fix-iOS8-orientation-handling' It takes @sammcewan fix, and it worked for me

RayzorDragon commented 10 years ago

I'm still having a problem with production builds on ios 8 beta devices still showing the popups sideways despite using the ios 8 fix branch. This does not happen when building debug builds on either my simulators or on my same ios 8 beta devices. Has anyone else experienced this?

pablogeek commented 10 years ago

I have this problem in iOS8

sammcewan commented 10 years ago

@pablogeek The popover is behaving correctly I suspect this could be something to do with implicit autolayout constraints. I would start there. If you find a fix please PR to my branch. I will surely accept. I'll have a look if I have time this weekend too.

danielwilliamson commented 9 years ago

I am also experiencing a problem where the view cuts off but only in a when selecting a particular cell in the third column. Very weird, the default popover works fine. Any help would be great. Thanks screen shot 2014-09-24 at 16 50 17

onmyway133 commented 9 years ago

Why not use a version check and use UIPopoverPresentationController for iOS 8 ?

https://developer.apple.com/library/ios/documentation/UIKit/Reference/UIPopoverPresentationController_class/index.html http://stackoverflow.com/questions/25319179/uipopoverpresentationcontroller-on-ios-8-iphone

You can write a wrapper like this FTGPopoverController https://gist.github.com/onmyway133/b62f79b885a71c41a22a

airbob commented 9 years ago

thank you so much @sammcewan !