search

nicolasdao / graphql-s2s

Add GraphQL Schema support for type inheritance, generic typing, metadata decoration. Transpile the enriched GraphQL string schema into the standard string schema understood by graphql.js and the Apollo server client.
Other
187 stars 15 forks source link

Added support for @aws_subcribe #16

Closed cameronrll closed 6 years ago

cameronrll commented 6 years ago

Added support for AWS AppSync subscriptions, mentioned in this issue

nicolasdao commented 6 years ago

Hi @cameronrll,

I've just reviewed your PR, and through you did a great job, your idea of whitelisting directives is not what I'd like to integrate as a fix. Somebody else had the same directives issue a while ago (https://github.com/nicolasdao/graphql-s2s/issues/10). I fixed that issue, but I've discovered that in case of AppSync, the @aws_subcribe directive is actually not defined inside in the schema definition. If it was defined explicitly, then that would work.

I'm currently working on a fix.

Thanks a lot for reporting that issue.

Cheers,

Nic