search

nicolasdao / graphql-s2s

Add GraphQL Schema support for type inheritance, generic typing, metadata decoration. Transpile the enriched GraphQL string schema into the standard string schema understood by graphql.js and the Apollo server client.
Other
187 stars 15 forks source link

Add support for generic types in parameters #20

Closed glennvgastel closed 6 years ago

glennvgastel commented 6 years ago

This PR will add support for generic types in type parameters. I've added the relevant test and modified the readme to reflect the new feature.

nicolasdao commented 6 years ago

Fantastic @Calcyfer .

I'm in holidays ATM and I'm back on the 8th in Sydney. I'll do my best to review that before. Worst case scenario, I'll review it on the 8th.

Thanks a lot for your work.

Cheers,

Nic

iamdanthedev commented 6 years ago

Hello guys Any luck with this PR? Seems to be a killer feature Thanks

glennvgastel commented 6 years ago

@iamdanthedev Not yet, as the maintainer hasn't had time to check them yet, but I'm using a combination of the 2 currently open PRs in a project right now.

Feel free to fork that branch.

iamdanthedev commented 6 years ago

@Calcyfer thanks for the link!

nicolasdao commented 6 years ago

Great work @Calcyfer.

I've just reviewed your PR and everything was fine. I've merged it and released a new version on npm (0.17.0). I'm looking for collaborators, so if you're interested, let me know so I can add you as a contributor to this project.

Thanks again.

Nic

glennvgastel commented 6 years ago

Thanks @nicolasdao.

I'd be happy to contribute, so feel free to add me and I'll track the project and update when and where I can.