Closed jimmed closed 5 years ago
Hi @jimmed ,
Thanks heaps for reporting this. This issue has already been reported by @yostools in https://github.com/nicolasdao/graphql-s2s/issues/17.
I'll try to fix this asap.
Really appreciate your support.
Nic
Any updates on this? Was a PR ever submitted? I ran into this issue today. Not a big deal, as we're not really using the descriptions, but it would be nice to be able to start adding them.
Hi @luisfrocha,
I haven't had time to fix that issue yet. I can't give you an ETA yet as I'm quite busy at the moment, but I'll try to fix asap.
Thanks for helping the community.
Cheers,
Nic
Hi,
I create a pull request to add the support of descriptions. If you don't have time to develop it, can you review the code i wrote ?
Thanks
Big thanks to @phoenix741 for fixing this issue. The latest release (0.19.1) on npm contains that PR. I'm closing this issue now. Thanks all for your support.
Fairly recently, the GraphQL spec was extended to add the concept of 'descriptions' ─ essentially comments describing types and fields.
For example (lifted from the spec):
Unfortunately, graphql-s2s cannot parse this new syntax; the following error is thrown at startup:
I'll take a look at fixing this myself and raising a PR, but I can't promise anything! Finally, thanks for creating such a useful library!