search

nicolasdao / graphql-s2s

Add GraphQL Schema support for type inheritance, generic typing, metadata decoration. Transpile the enriched GraphQL string schema into the standard string schema understood by graphql.js and the Apollo server client.
Other
187 stars 15 forks source link

Fixing empty query arguments critical error #31

Closed Larinel closed 5 years ago

Larinel commented 5 years ago

When supplied an empty arguments list to query - build fails Ex.

type Query {
  ping(): String!
}

Was producing an error on building.

Now it successfully building to

type Query {
  ping: String!
}
nicolasdao commented 5 years ago

Awesome @Larinel,

I've just reviewed your PR and all seems good. Thanks a lot for also submitting the unit test and sticking to our PR rules. That way, your PR is not just great, it is freaking awesome ;)

I've just bumped the version of our lib from 0.18.1 to 0.18.2.

On behalf of our community, thanks a lot :fire: :+1: :star: :heart:

Cheers,

Nic