search

nicolasdao / graphql-s2s

Add GraphQL Schema support for type inheritance, generic typing, metadata decoration. Transpile the enriched GraphQL string schema into the standard string schema understood by graphql.js and the Apollo server client.
Other
187 stars 15 forks source link

duplicate property #33

Closed yasintz closed 5 years ago

yasintz commented 5 years ago

Screenshot_8 can you prevent this from happening ? it shouldn't be too hard

nicolasdao commented 5 years ago

Hi @yasintz,

Can you provide the schema before it is transpiled to see how to recreate this error?

I've seen your PR. That seems great, so thank you so much for jumping in. Our community development guidelines require that you also provide the unit test. Add that to you PR and I'll gladly finish your PR review before merging it to master.

To add a unit test, follow the explanations described in the README here: https://github.com/nicolasdao/graphql-s2s#contribute

In your case, you'll add your unit test under:

describe('graphqls2s', () =>
    describe('#transpileSchema', () => {
      ...
      it('26 - FIX: Should not duplicate properties', () => {
            Your unit test here
      })
    })

Thanks a lot for reporting that issue @yasintz as well as jumping in to fix it.

Cheers,

Nic

yasintz commented 5 years ago

i updated my pr. Thanks for this library. it works exactly.

yasintz commented 5 years ago

Why not use typescript ?

yasintz commented 5 years ago

it's so hard to understand. Why don't you file the functions ?