search

nicolasff / webdis

A Redis HTTP interface with JSON output
https://webd.is
BSD 2-Clause "Simplified" License
2.82k stars 307 forks source link

port unittests to python3 #173

Closed sandrotosi closed 4 years ago

sandrotosi commented 4 years ago

Hello, as part of the Python2 removal effort in debian, i've just ported the unittests to python3, here attached the patch i used; please feel free to include it in this repo.

Regards, Sandro

webdis-python3.patch.txt

nicolasff commented 4 years ago

Hi Sandro,

Thanks for the patch, that's great! Do you want to re-open this issue as a pull request so that you appear as the author of this change in git logs, and get credit for this work? The CI job will likely fail since the validation step uses Python 2.7, but I can address that once the changes are merged.

sandrotosi commented 4 years ago

naah i really dont care about credit, just apply and merge it :)

nicolasff commented 4 years ago

I've integrated your patch. Thanks again!