search

nicolasff / webdis

A Redis HTTP interface with JSON output
https://webd.is
BSD 2-Clause "Simplified" License
2.82k stars 307 forks source link

Implement Redis v6 auth (fixes #182) #183

Closed jessie-murray closed 3 years ago

jessie-murray commented 3 years ago

There are 3 commits in this PR:

  1. 4640ac0 adds support for Redis 6 auth with a username and password
  2. f159c7f fixes an issue I noticed in slog.c while writing this
  3. d3d40bd adds logging for the AUTH command; webdis is currently ignoring the response from Redis and just relying on later commands failing to notify users that the current config doesn't work correctly

CC @nicolasff

jessie-murray commented 3 years ago

@nicolasff I added a new commit with the bugfix for the error message logged when auth is disabled, also I updated conf_free to fully free the redis_auth struct but then I noticed that it is never called since Webdis just exits with exit(0) so I was not really sure what to do.