Open jollyroger opened 10 years ago
Bump. Nicolas, I just cannot add webdis to the Debian distribution because it fails tests on a newer (and now default) version of python-msgpack. Please look on this issue.
Nicolas,
It seems, msgpack has switched to using lists instead of tuples in failed tests. I have added patch to make tests pass. See this patch for details: https://github.com/jollyroger/webdis/blob/e1d629ea94362bb7fd9a63f574e419b41298cc84/debian/patches/tests.patch
Friendly bump. Do you want me to send Pull Request that fixes the tests?
A pull request would be much appreciated!
On Aug 22, 2018, at 3:01 AM, Andrii Senkovych notifications@github.com wrote:
Friendly bump. Do you want me to send Pull Request that fixes the tests?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
@nicolasff I've created pull request for this issue (and some others) as you requested. Hope they are fine.
Nicolas, I've found that webdis fails msgpack-related tests using python-mspack with version 0.3.0. All tests pass with python-msgpack version 0.2.0 installed. However this package only is available in Debian and not Ubuntu. This affects recent Ubuntu versions(saucy and upcoming trusty), here is detailed output:
These errors do not appear for Debian jessie(current testing) and sid(unstable). Debian has two packages related to python and msgpack that are used in the test suite:
python-msgpack
with version 0.3.0 of the library andmsgpack-python
with version 0.2.0 of the same library. Ubuntu has justmsgpack-python
package that points to the 0.3.0 version. I assume version 0.2.0 will be dropped soon from Debian as well.