Add PuppetV2 - Githubissues

nicolasgarcia214 / damn-vulnerable-defi-foundry

Damn Vulnerable DeFi - Foundry Version

MIT License

494 stars 189 forks source link

Closed jeffchen006 closed 2 years ago

jeffchen006 commented 2 years ago

Install two libraries uniswap/v2-core and uniswap/v2-periphery which are required by PuppetV2
Rewrite original javascript file into Puppetv2.t.sol
Test it locally, works correctly using my solution code

nicolasgarcia214 commented 2 years ago

Hi Jeff, I'll check it tomorrow 👍 Thanks for contributing.

nicolasgarcia214 commented 2 years ago

Refactor PuppetV2Pool to 0.8.12 (remove SafeMath and use custom errors for consistency).
Use a separate file for the interfaces used in the PuppetV2 contract.
Make use of a formatter like Prettier (when I have some free time I'll add a Github action for that).
Remove v2-core dependency (not necessary).

jeffchen006 commented 2 years ago

Hi Nicolás, @nicolasgarcia214

Thanks for your comments. Pushed some new commits. Please review it when you have time.

v2-core dependency is required by many files in v2-periphery. I don't think they can be removed easily.