search

nicolashmln / strapi-plugin-responsive-image

Custom responsive image formats for https://strapi.io
154 stars 28 forks source link

sharp issue on strapi 3.6.8 #13

Closed cruonline closed 2 years ago

cruonline commented 2 years ago

Hi,

I have just run into some issues with sharp after updating to the latest strapi (3.6.8) and responsive-image 0.5.0

Something went wrong installing the "sharp" module

Rolling pack responsive-image to 0.4.0 solves the problem. I have noticed, you have bumped sharp dep, to 0.29.0 however, strapi is still on 0.28.1

So, question is, why not move sharp dependency, to peer dependencies, so we rely on packages already in place from strapi?

nicolashmln commented 2 years ago

To have the lastest updates for the avif format.

Did you try to remove the package-lock.json file and the node_modules folder and run the npm install? I have tested with the 3.6.8 version of strapi and I have no problem.

cruonline commented 2 years ago

I have tried clean install, with both node_modules and yarn-lock deleted. (Also, using yarn, not npm, and windows 10 for good measure :) ) I guess I will stick to 0.4.0 until strapi updates sharp to the latest version.

dirq commented 2 years ago

I have the same problem with Sharp. Windows 10. Moved back to 0.4.0 and it runs BUT I wanted this for the webp support.

dirq commented 2 years ago

How did this issue get closed?

cruonline commented 2 years ago

I guess no love for devs on windows machines ;-)