search

nicolaskruchten / pivottable

Open-source Javascript Pivot Table (aka Pivot Grid, Pivot Chart, Cross-Tab) implementation with drag'n'drop.
https://pivottable.js.org/
MIT License
4.36k stars 1.08k forks source link

No thousandsSep #914

Open psohm opened 6 years ago

psohm commented 6 years ago

Hello I'd like to remove thousandsSep is it possible ? When I write that format the component isn't loaded

            var intFormat = numberFormat({thousandsSep:'',digitsAfterDecimal: 0});

Regards

kjeldahl commented 5 years ago

The problem is in this line https://github.com/nicolaskruchten/pivottable/blob/60389139da818ff3dc2f0243c7be72bf0b54a73b/src/pivot.coffee#L22 in the while part as there are no changes to the string x1 if thousandsSep is the blank string. A check should be added in case thousandsSep is blank.