Persisting login state, event hooks for login/logout, simplified API

nicolaslopezj / meteor-apollo-accounts

Meteor accounts in GraphQL

MIT License

145 stars 35 forks source link

Persisting login state, event hooks for login/logout, simplified API #31

Closed META-DREAMER closed 7 years ago

META-DREAMER commented 7 years ago

Add initWithClient(apolloClientInstance) function to remove need for passing apollo with every function call
Calling userId() is now synchronous and more performant since it's cached in memory
Added the following hooks/callbacks: onLogin, onLoginFailure, onLogout so the API is similar to Meteor Accounts
Added loggingIn function, similar to Meteor Accounts
Added support for persisting login automatically. As soon as you call initWithClient in your app, it will check for a stored token and attempt to login, calling the onLogin callback if it succeeds.

nicolaslopezj commented 7 years ago

This is great! thanks for the contribution.

Can you separate this pull request into 5 different? It's too hard to review so many changes all in once

META-DREAMER commented 7 years ago

@nicolaslopezj Alright, I split it up as much as I could. Once you merge #35 I can make a pull request for the rest of the stuff since it builds on the stuff in #35.

META-DREAMER commented 7 years ago

@nicolaslopezj Alright all the changes are split up into separate pull requests. You can ignore this pull request. Merge #33 and #34 first, and after that merge #35 to #38 in order since they each build on each other. Let me know if this works!

Would love to see this published to atmosphere and npm soon so I can get it working in my app without hacks. Since the client package is a subfolder of the repo, npm doesnt let me install the package with the git URL, really annoying haha.