search

nicolaslopezj / searchable

A php trait to search laravel models
MIT License
2.01k stars 291 forks source link

null coalesce operator in php >= 5.4.0 ? really? #196

Open pbtlt opened 5 years ago

pbtlt commented 5 years ago

This version positioned is to run on php 5.4.0+ but following code will not be compiled on versions under 7.0

protected function getRelevanceField() { if ($this->relevanceField ?? false) { return $this->relevanceField; }

baratimur commented 5 years ago

"nicolaslopezj/searchable": "1.10.*" for php 5

problematic commit : https://github.com/nicolaslopezj/searchable/commit/3874f6680347c072acfdd06ca1636e32cffba838#diff-a684410f1c0c617785bc98acd92b7aa2