search

nicolaslopezj / searchable

A php trait to search laravel models
MIT License
2.01k stars 291 forks source link

laravel 6 #200

Closed scripta55 closed 5 years ago

scripta55 commented 5 years ago

hi, just curious to know if you will have an update for laravel 6? thanks

leknoppix commented 5 years ago

Hi, I have try to update to laravel 6 but, I can't. I have try to a new project build in laravel 6, I have error.

scripta55 commented 5 years ago

there is a pull request pending, someone has already done it, we are just waiting on nico to accept :)

Kind Regards,

Peter Phillip +27 72 900 6987 (South Africa) +265 99 566 3635 (Malawi) +258 84 767 1178 (Mozambique) +27 21 813 9934 (International Roaming) Nothing will work unless you do.

On Sun, Sep 15, 2019 at 6:21 PM Cañadas Pascal notifications@github.com wrote:

Hi, I have try to update to laravel 6 but, I can't. I have try to a new project build in laravel 6, I have error.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nicolaslopezj/searchable/issues/200?email_source=notifications&email_token=AASMQLVBSSAD7HTDNNTZAX3QJZOJXA5CNFSM4IVUL3MKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6XUAYQ#issuecomment-531578978, or mute the thread https://github.com/notifications/unsubscribe-auth/AASMQLRLNABR62XSHITNWQ3QJZOJXANCNFSM4IVUL3MA .

JhumanJ commented 5 years ago

So PR was merged, but new version isn't released (on packaggist at least)... What can we do about it ?

nicolaslopezj commented 5 years ago

I can see the version 1.12.0 published in packagist

image

JhumanJ commented 5 years ago

My bad ! That was not the case yesterday so I couldn't complete my migration to L6.