incognito: split mode does not work correctly with InPrivate browsing

Describe the issue

When run in "split" mode there are several issues with uBlock:

Dynamic filtering does not appear to work at all.
While browsing on an InPrivate session the uBlock menu does not display connected or blocked domains properly. It will just show the root domain but the color coding doesn't show.
I believe it still does filter correctly with whatever filter lists are enabled but I did not verify it that much.
The logger also doesn't work right from what I could tell.

All of the above appear to be related to how Edge runs extensions which specify incognito: split. Forcing it to run in spanning mode at least makes it look like everything is running correctly. Dynamic filtering works again properly, uBlock menu functions correctly, etc...

May be related to #116

I'm curious what the implications are of running the extension in spanning mode. I don't mix regular/private browsing windows so I doubt there is any for my case.

One or more specific URLs where the issue occurs

N/A

Screenshot in which the issue can be seen

N/A

Steps for anyone to reproduce the issue

See above. Run the extension with the default split mode. Then try again in spanning mode. Notice everything works again in spanning mode for InPrivate windows.

Your settings

OS/version: Windows 10 1803
Browser/version: Edge/17.17134 (latest as of 8/2018)
uBlock Origin version: I tried both the store version then git HEAD (1.16.6). Reproducable on both although you'll have to sideload to change the manifest properties.

Your filter lists

N/A You can run with defaults or everything.

Your custom filters (if any)

N/A

First, I agree that in current mode, it does not work at all in private windows. Menus don't function, etc.

Regarding the incognito manifest property, here is the doc : https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/incognito

So I guess putting it in spanning mode wouldn't break anything, it would make it work like in Firefox, where the settings are shared between incognito and non-incognito windows. This is what we'd want, anyway, because it would be annoying/painful to define dynamic filtering two times, one for regular mode, and one for inPrivate mode.

If your testing indicates that setting this parameter to spanning makes uBlock work correctly in inPrivate mode in Edge, it would be nice to integrate the change in the build (for me, no uBlock in private mode is a deal breaker), it looks a simple fix and huge benefits.

nicole-ashley / uBlock-Edge