nicoledag
commented
6 years ago Thank you for the thorough and detailed review. I really enjoyed the course and I look forward to keep learning and advancing my skills. Nicole
Open rimmesbe opened 6 years ago
nicoledag
commented
6 years ago Thank you for the thorough and detailed review. I really enjoyed the course and I look forward to keep learning and advancing my skills. Nicole
Grade: Satisfactory
Summary: Nice job on this project, the site looks very good on both desktop and mobile. You used a lot of good techniques and enhanced the design styled nicely. Take a look at the issues I created for some best practice tips as well as some new techniques you can start applying. Your site looks very good, not it is time to make your code look as good. Work on your indentation and look into adopting an official CSS naming convention. I like BEM, but there are many out there: http://getbem.com/introduction/
Well done, I hope you enjoyed the course!
Somethings to look into for future learning: SASS, CSS grid, CSS variable, Bootstrap or Foundation, aria roles, SEO optimization