search

nicolegooden / mod_0_skills

0 stars 0 forks source link

Assessment results #1

Open damwhit opened 4 years ago

damwhit commented 4 years ago

@nicolegooden really nice work on this! It's clear you have a good grasp of the OOP concepts we've gone over in mod 0. Great job following proper conventions. You're also naming your methods in a way where it's very clear to me what attribute they're going to affect and how. Keep up the good work moving forward!

Something to think about moving forward: How could you change your Menu class to have a dishes array, that is made up of objects (js data type) with name and price attributes?

nicolegooden commented 4 years ago

@damwhit Thank you for this feedback! I've enjoyed the OOP concepts so far, especially since they require so much precision (really makes me think).

I've made an attempt at your suggestion for the Menu class. Please check out this repl and let me know what you think!

https://repl.it/join/mbieboia-nicolegooden

nicolegooden commented 4 years ago

@damwhit Here is my second attempt, where I experimented with creating the array of objects rather than strings:

https://repl.it/join/lsarldul-nicolegooden

damwhit commented 4 years ago

Looks good! The only thing I would update is the name of the class. I think MenuItem might be more appropriate in this case

nicolegooden commented 4 years ago

@damwhit

Got it, I updated it in the repl. Thanks!