search

nicolehappy / Deliverable3

0 stars 0 forks source link

Grading notes #1

Open asphaltpanthers opened 7 years ago

asphaltpanthers commented 7 years ago

Hello @nicolehappy,

You did a fine job designing and writing these tests. You chose element selection methods, you used assertions well, and you used the WebDriverWait correctly.

There were only two small issues.

When the tests finished executing, the Firefox browser was not closed. This causes resources to be wasted on the test machine and is especially important when running large suites of tests.

The Thread.sleep() is used once in your tests. It is never good practice to use the Thread.sleep(). The WebDriverWait should be used instead.

asphaltpanthers commented 7 years ago

Check CourseWeb for your grade.