Hw01 Ready For Grading - Githubissues

nicolehawe / STAT545-HW-Hawe-Nicole

Homework Submission

0 stars 1 forks source link

Hw01 Ready For Grading #1

Open nicolehawe opened 7 years ago

nicolehawe commented 7 years ago

Thanks for taking the time to check this out! @vincenzocoia @gvdr @ksedivyhaley @joeybernhardt @mynamedaike @pgonzaleze @derekcho

shadowforti commented 7 years ago

Hello Nicole

Nicely Done!

From the readme, you have created header line, bold, italic, link as well as bullet form. You have well described what you have done and steps in creating the readme and gapminder data exploration. The documents are well named with both rmd and md. You have also demonstrated the gapminder data exploration well including a link to md.

Personally, I think it would be better to have some picture in your intro to make it cooler. Also, for some reason, I could not see the plot you have embedded. Maybe it is problem from my side. Great job on your first assignment!

Jian

nicolehawe commented 7 years ago

Thanks for the feedback @shadowforti

CassKon commented 7 years ago

Hey!

What you did:

Used different headings, links, bold, italics, lines – definitely tried out different formatting options!
Added more to readme file than just name
Made clean, detailed point form notes about the process

Potential Issues:

One of the headings needs a space after the ## (##Overview). I used the edit and preview changes buttons on GitHub to check this out and it seems that adding a space will make ‘Overview’ a proper heading!
I was able to get to your Gapminder exploration homework but I wasn’t able to view the figures properly on the .md file. This could be just me but might be worth looking into.

Overall, I think that you covered all of the basics of the assignment! I also like how you added organization with the different homework folders.

-Cassandra

JoeyBernhardt commented 7 years ago

Correctly named issue: Yes Link to work to be reviewed: in README Use 4 or more aspects of markdown: Yes (headings, list, formatting, links) Reflections / how it was done: Yes Gapminder exploration: No

Comments:

Nicely done! Next time try to push your markdown skills a little further by adding some images, or gifs even! I see you didn't really get to the Gapminder exploration part of the assignment, but that's ok since it was optional.

Note: your mark will be sent out later.