search

nicolej2122 / pe

0 stars 0 forks source link

Incorrect Archive Command Activity Diagram #7

Open nicolej2122 opened 2 years ago

nicolej2122 commented 2 years ago

Screenshot 2021-11-12 at 5.27.18 PM.png Screenshot 2021-11-12 at 5.27.18 PM

The two arrows from the 'Throws CommandException' and 'Prints Success message to user' must be conjoined by a diamond shape before reaching the endpoint.

The guard conditions are also not enclosed within square brackets.

nus-pe-bot commented 2 years ago

Team's Response

The mistake made here is valid but is only a minor notation error and should only warrant a very low severity at most.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: Although the readers may understand what the activity diagram conveys, the entire point of having UML is to have a unified notation and non-compliance to this make using UML notation pointless, as you could have used any diagram to convey the same point. The severity is at least Low.