search

nicolesteck / newProject

Individual Project take 2
https://youtu.be/B42uit5400E
0 stars 0 forks source link

Peer Review #2

Closed Assoman closed 6 years ago

Assoman commented 6 years ago

Design/Code Review 3

Project:

Developer: Nicole Steck

Reviewer: Osamah Shareef

Category Criteria Rating/Comments
Project Overview
Which planned functionality has been met? Most planned functionality has been met. All CRUD applied.
What planned functionality has not been met?
Describe the GitHub history and what it demonstrates about the project progress during the semester.
Describe how peer and instructor feedback/recommendations were incorporated into the project.
Other comments/notes?
JSPs
Evaluate the JSPs for templating, business logic, data validation, overall look and feel.
Other comments/notes? Maybe adding a dynamic display for pages according to the user session.
Java code quality Evaluate the code quality for the following and identify specific areas for improvement (class, method or line number)
  • single-purpose methods
  • well-structured project
  • descriptive naming of packages, classes, methods, variables
  • classes appropriately-sized (no monster classes)
  • CPD (copy paste detection, meaning are the same lines of code repeated?)
  • are there candidates for super/subclass relationships, abstract classes, interfaces?
  • are any values hard-coded that should be in a properties file?
  • proper exception handling
  • proper error reporting to the user
  • code documentation
    		•  No CPD noticed, proper exception handling, and well-structured project.
    Other comments/notes? Maybe adding the error page and forward all the errors to this page, also adding the logout functionality which is important to terminate the session.
    Logging Evaluate the use of logging, for example:
  • appropriate use of logging statements in the code for error logging and debugging
  • logging levels used - info, debug, error
  • no occurrences of System.out.printlns or printStackTrace()
  • logging works on AWS deploy
    		•  No System.out.println used
    Other comments/notes? Try checking the logging on AWS.
    Unit Tests Evaluate the unit tests, for example:
  • tests are truly a unit test rather than a high level functional test
  • test data is appropriately cleaned up or handled
  • there is full coverage of methods that perform business logic or utility functions
  • redundant code is eliminated by using set up and tear down methods, i.e., @Before, @After
    		•
    Other comments/notes?
    Security Evaluate authentication/authorization: No flaws.
    Is it implemented correctly and working locally as well as on AWS?
    Other comments/notes?
    Web Service/API integration Evaluate the service/api integration, for example:
  • Which service/api is implemented?
  • How is error handling of the service implemented? For example, what happens if the service is not available?
    		•  Linkden API
    Other comments/notes?
    Independent research topic What is the independent research topic?
    Is the independent research topic/technique implemented in the project?
    Other comments/notes?
    Deployment Has the application been successfully deployed to AWS?
    Is the hosted application fully functioning?
    Other comments/notes?
    nicolesteck commented 6 years ago

    Made all suggested changes, thanks Osamah!