search

nicolgit / whoiswho

azure WhoIsWho engine
MIT License
4 stars 2 forks source link

.net 5 #45

Open nicolgit opened 3 years ago

nicolgit commented 3 years ago

just found this

https://azure.microsoft.com/en-us/updates/general-availability-azure-functions-supports-net-5-in-production/

@fume @liguori do we want to upgrade to .net 5 all?

liguori commented 3 years ago

@nicolgit I was playing a little bit with the isolated model (.NET 5) but at the moment I would avoid to use it given the little support of the development tools: https://github.com/Azure/azure-functions-dotnet-worker/issues/331 https://stackoverflow.com/questions/67013422/upgrading-azure-functions-to-5-0-system-uriformatexception

We can plan to reserve this conversion at the end of the other tasks. In the meantime we can bring back to .NET 3.1 the 'whoiswho\api\api.csproj' in order to have a consistent deployment of the same version of all the Function Apps.

nicolgit commented 3 years ago

Make sense to wait for a while before migrating all to .Net 5.

Now API looks working, I'd keep them in .Net 5 flavour as long as we incur in some blocking issue...

liguori commented 3 years ago

I don't know if it work seamlessy with ARM template and GitHub actions that we already have for the Function App with .NET 3.1 @nicolgit look at this PR: https://github.com/nicolgit/whoiswho/pull/49

I have already prepared / reused the existing code for 3.1 applied to the "WhoIsWho.Portal.API"

I would keep everything at 3.1 and then update

nicolgit commented 3 years ago

let's remain in 3.1 for the moment