search

nicomuratona / MuEmu-0.97k-kayito

Full Install Guide: https://youtu.be/P_CUCu7a_Dw
35 stars 38 forks source link

Fix buffer overrun in ChangeWindowText #23

Open lineagedr opened 6 days ago

lineagedr commented 6 days ago

Fixes buffer overrun when running the game in Release mode.

In the future It would be nice to replace all C style arrays with C++ array class, it's much safer and has no overhead.

Thank you for the sources you've provided, I may not have any experience with Mu Online, but starting with your files will help me to learn the game. :heart:

Closes: https://github.com/nicomuratona/MuEmu-0.97k-kayito/issues/22

nicomuratona commented 6 days ago

In the next update is already fixed by using class member array to save the window name in each scene change. Will be uploaded soon, i'm working on some systems to add.

lineagedr commented 6 days ago

In the next update is already fixed by using class member array to save the window name in each scene change. Will be uploaded soon, i'm working on some systems to add.

That's great to hear, I can't wait to see the new update.