search

nicor88 / aws-ecs-airflow

Run Airflow in AWS ECS(Elastic Container Service) using Fargate tasks
MIT License
159 stars 76 forks source link

Referenceability as terraform module #14

Open aaronsteers opened 4 years ago

aaronsteers commented 4 years ago

I found this repo via google search and it seems like a great starting point for a project I'm starting on.

Rather than forking the repo, I'm curious if you have any interest in updating the layout of the terraform scripts in order to match the convention of having a core main.tf, outputs.tf and variables.tf for the primary use case(s). This would make the repo more easily referenceable, which could allow one to plug this into other environments more easily.

Feel free to say "no" if that's not the direction this project is going. (Thanks very much either way!)

aaronsteers commented 4 years ago

Sample PR: https://github.com/nicor88/aws-ecs-airflow/pull/15

nicor88 commented 4 years ago

@aaronsteers I like the idea of having modules in terraform. This repo contains the really first iteration. I need to have some time to take a look into this.