search

nicorac / bcr-gui

BCR-GUI is a companion app for the great BCR (Basic Call Recorder) Android application and other supported ROMs with embedded call recorders.
https://coolsoft.altervista.org
GNU General Public License v3.0
146 stars 7 forks source link

Does not look in subdirectories #12

Closed cao- closed 10 months ago

cao- commented 1 year ago

With BCR you can specify in the filename template subdirectories, and so calls can be saved in different subdirectories. This GUI looks only at the top level folder, and doesn't show calls present in subdirectories. There should be an option to allow the recursive scan of subdirectories too. Thanks

nicorac commented 1 year ago

There should be an option to allow the recursive scan of subdirectories too.

Yes, subfolder access is actually not available but, sadly, I don't know if I'll be able to support it in the near future...

Let me explain: both BCR and BCR-GUI need to access recordings folder through Android SAF (Storage Access Framework) because, starting from Android 10, that's the only way to access any (user selected) folder on the phone.

While this seems good, the other side of the coin is that some SAF implementations performances are really bad. Even @chenxiaolong discourages using it in BCR readme.

BCR-GUI features a customized file caching to overcome this slowness, and it seems to work perfectly with huge folders (I've tested with 2000+ files on a mid-range test phone). Supporting subfolders requires me to deeply rewrite it 🤔.

With BCR you can specify in the filename template subdirectories, and so calls can be saved in different subdirectories.

I suppose you're using subdirectories to "TAG" your recordings, right?

Well, if I'm right then you'd be happy to know that I'm going to add full TAG support to BCR-GUI.

I mean users will be able to apply custom TAGs to their recordings, like WORK, PRIVATE, FRIENDS and so on; no need to move them to subfolders. You could also apply more than one tag to the same recording.

cao- commented 1 year ago

No problems if you're not going to support it, you convinced me to not use subfolders :) Thanks for your reply and your work on this app.

symbuzzer commented 11 months ago

@nicorac If you consider adding this feature, I would like to help you translate the application into Turkish freely.

I'm not imposing any conditions, don't get me wrong. However, I cannot use the application in its current state and it does not seem reasonable to translate for an application that I do not use.

nicorac commented 11 months ago

This feature is already on the TODO list, don't worry 😉 But other bugs are on top of this because app could be unusable on some conditions (like #9 and #13).

I would like to help you translate the application into Turkish

This is something that will happen in the future, thanks for it 👍

nicorac commented 10 months ago

This feature is already on the TODO list, don't worry 😉

Well, I meant I'll add the "TAGS" feature, not the subdirectory one...