search

nicorac / bcr-gui

BCR-GUI is a companion app for the great BCR (Basic Call Recorder) Android application and other supported ROMs with embedded call recorders.
https://coolsoft.altervista.org
GNU General Public License v3.0
138 stars 7 forks source link

On GrapheneOS AMR files are not supported and detected #81

Closed Mattrazol closed 6 months ago

Mattrazol commented 6 months ago

Describe the bug If on GrapheneOS in the voice recording I select AMR-WB as the "Audio output format" the files that are generated by the recording (files .amr) are not recognized by the app (even if they correctly match the regex) and therefore they are not displayed on the list of recordings (Home).

To Reproduce Steps to reproduce the behavior:

  1. Open the app
  2. Select a folder containing recordings from GraoheneOS that are in .amr format
  3. The home screen doesn't detect any of them

Expected behavior The files should be displayed and be able to be reproduced just like AAC or other audio format file

Versions (please complete the following information):

nicorac commented 6 months ago

BCR-GUI does not filter files by extension but on MIME type (returned by Android SAF - Storage Access Framework).

These are the MIME types currently supported: https://github.com/nicorac/bcr-gui/blob/0e47940595c2ea4421aac5a2e2081210ac678b76/src/app/services/settings.service.ts#L120

.amr MIME type should be something like audio/amr. Could you confirm it? (you could see it with a filemanager, details...) Otherwise I could try to create one .amr file on my side...

Mattrazol commented 6 months ago

I've tried to look for the mime-type with a few file manager but I couldn't figure it out. But by looking online it seems like you might be right the mime type should be "audio/AMR" I would double check though because I didn't invest too much time into it

nicorac commented 6 months ago

Here's a build that adds support for audio/amr MIME type files.

bcr-gui-1.5.0-release-with-amr-support.apk.zip

Please confirm that it both shows (after a refresh) and plays AMR files correctly.

NOTE: it has the same 1.5.0 version of the latest official version...

Mattrazol commented 6 months ago

Yes it works perfectly! Thank you so much!

nicorac commented 6 months ago

Great, thanks for your feedback. Will merge the change to dev branch, so you'll find it in next release. Feel free to use this build since then.