search

nicoriff / ORMi

A Light-ORM for accesing WMI
MIT License
209 stars 28 forks source link

use dispose method #28

Closed kevwkev closed 3 years ago

nicoriff commented 3 years ago

Hi @kevwkev great code refactoring. Seems great improvements on efficiency. Have you tested all the changed CRUD methods?.

kevwkev commented 3 years ago

Hi @kevwkev great code refactoring. Seems great improvements on efficiency. Have you tested all the changed CRUD methods?.

Hi @nicoriff thanks! I haven't tested all the methods. I just simply wrap the IDisposable object in a using statement, theoretically, it shouldn't affect their functionalities.

nicoriff commented 3 years ago

@kevwkev code wasn't compiling. There were some conditional IF statements that were being open inside using statements and closed outside. Fixed it on commit 13fcb9d