Closed dkebler closed 9 years ago
Awesome!
I'll check to see if there's any way to know if the panel is open to make a toggle later, but just a question, instead of running Gulp: Hide panel
, you could just press Esc
, right? or there's a use case I'm not seeing?.
I'm re-reading the README and trying out the menu before merging. I'll let you know if there's any issue, thanks a lot for the PR!
Already noticed a couple typos :-).
never new esc was used like that :-). I just saw your code already had such a fucntion so just enabled it.
I say leave it in for unknowing folks like me but might as well mention esct in the readme.
I'm fixing few typos and adding that note. Look for new commit.
On Wed, Aug 19, 2015 at 5:29 PM, Nicolás Santángelo < notifications@github.com> wrote:
Awesome! I'll check to see if there's any way to know if the panel is open to make a toggle later, but just a question, instead of running Gulp: Hide panel, you could just press Esc, right? or there's a use case I'm not seeing?.
I'm re-reading the README and trying out the menu before merging. I'll let you know if there's any issue, thanks a lot for the PR!
— Reply to this email directly or view it on GitHub https://github.com/NicoSantangelo/sublime-gulp/pull/45#issuecomment-132836211 .
Cheers, Cuidate, TTFN http://www.youtube.com/watch?v=5Gu50vq5ux4 David
I like this a lot! I didn't find typos but I'll give it another read before merging with master.
I'm going to merge this PR, make a few additions (listed below) and release this!
Todo:
Gulp: Hide panel
check if results_in_new_tab
is true
and see if I can close the tab or just do nothing (right now is failing)gulpfile.js
file, the package won't prompt the selection)And, this last two if you think is better:
Run Default Task
for Run Arbitrary Task
when this last one is readyThanks again and let me know
On Thu, Aug 20, 2015 at 10:53 AM, Nicolás Santángelo < notifications@github.com> wrote:
I like this a lot! I didn't find typos but I'll give it another read before merging with master.
I'm going to merge this PR, make a few additions (listed below) and release this!
Todo:
- When using Gulp: Hide panel check if results_in_new_tab is true and see if I can close the tab or just do nothing (right now is failing)
- Check if I can add the current selected path on the sidebar (if the user has more than one project with a gulpfile.js file, the package won't prompt the selection)
And, this last two if you think is better:
- Change Run Default Task for Run Arbitrary Task when this last one is ready
- Add your Github handle to Acknowledgments :)
Thanks again and let me know
— Reply to this email directly or view it on GitHub https://github.com/NicoSantangelo/sublime-gulp/pull/45#issuecomment-133097634 .
Cheers, Cuidate, TTFN http://www.youtube.com/watch?v=5Gu50vq5ux4 David
Run Default Task
Merged! I'll create the release as soon as I can, thanks a lot for the help.
Nick,
Added hide panel command, added main menu items and new side bar menu items (see new readme). Extensive rewrite of readme file with new features and clarification of old ones.
Hope you like it :-). Readme is heavily edited so even if you like it you should read it carefully for clarity, errors and typos. I did check all the links and anchors.
I thought adding a hide panel command would be nice as that's the first thing I wanted to be able to do and it compliments the show panel command. Unfortunately I can't get anyone at superuser to help me figure out how to turn it into a toggle menu item.
I pulled your latest before making the PR so looks like it is ok to merge with your branch.
Cheers!
PS Had a thought about an improved list plugins command but will make that a new enhancement issue.