search

nicosantangelo / sublime-gulp

Run Gulp tasks and use snippets from Sublime Text
https://sublime-gulp.nicosantangelo.com/
MIT License
155 stars 18 forks source link

Fixed taskkill path for Windows #70

Closed atnartur closed 8 years ago

atnartur commented 8 years ago

I tested this code on my computer with Windows 10 and gulp process killed successfully.

nicosantangelo commented 8 years ago

Thanks a lot for the patch and sorry for the delay, my GitHub settings changed at some point for some reason and I wasn't getting any email notifications.

Let me give it a try on my Windows box and I'll let you know/merge it

Thanks again!

nicosantangelo commented 8 years ago

Update: Sorry for the delay, just wanted to let you know that testing this in different Windows systems proved to be more difficult than expected but it's working great!

It should be merged by tomorrow

atnartur commented 8 years ago

Great! Thanks!

nicosantangelo commented 8 years ago

All good!.

This will be on v5.5.0, released tomorrow. Thanks a lot for the find 🎉