search

nicosantangelo / sublime-gulp

Run Gulp tasks and use snippets from Sublime Text
https://sublime-gulp.nicosantangelo.com/
MIT License
155 stars 18 forks source link

Fix default codepage detection on windows #90

Closed FelixBoers closed 6 years ago

FelixBoers commented 6 years ago

chcp on a german windows returns: Aktive Codepage: 850.\r\n

Because .strip() only removes blank and line breaks 850. becomes the name of the codepage.

In order to remove the dot from the name we've to add it to the list of characters we have to remove.

Fixes #89

nicosantangelo commented 6 years ago

Awesome! I'll test it a bit in a few scenarios and let you know how it goes (I'll deploy it along with #91 )

FelixBoers commented 6 years ago

Great! Thanks for your reply.

nicosantangelo commented 6 years ago

All good! I'll deploy it as part of 6.1.2

Thanks a lot