Project Feedback

[nicoskia]

@egillespie Can you take a look at this? It's hosted here and meets the following criteria:

• [x] All components in this HTML are styled using Sass
• [x] Use four colors from a random color palette (just copy the hex values into your Sass file) and link to your palette in the HTML
• [x] Font sizes are all determined by one base font size variable, even in input and textarea elements
• [x] All text uses the same font family, even in input and textarea elements
• [x] Elements shaped like a box (img, input[type="text"], textarea) have the same border-radius
• [x] At least one built-in Sass function is used to style a component
• [x] Variables are defined in their own Sass file
• [x] Sass files are saved in a source directory and CSS files are saved in a compiled directory
• [x] A source map for your component library is included in the project

[egillespie]

Hi @nicoskia, this is a pretty good start. It looks like all of the basics are covered, with the exception that img does not have a border-radius applied to it.

Your input and textarea elements are inconsistently styled. I recommend using a single set of styles for both elements and adding a border attribute:

input,
textarea {
  // existing styles go here
  border: 1px solid black;
}

I also don't see any styles being applied to label or any part of the table. Do you mind including those? Bonus props if you zebra-stripe the table and/or add an effect to the labels when you move the mouse over them. 😉

---

After you’ve made your changes and pushed them to GitHub and your hosted site, give it a once-over to make sure it looks right, then comment back here and I’ll take another look.

Thanks! 🥁

[nicoskia]

I applied a border radius to img, correctly styled input and textarea, and styled both label and table. Check for bonus tasks too :) Thanks!

[egillespie]

Thanks for cleaning house. I like the hover effect, too! 🌮

On my first pass, I didn't notice that you are not styling your a elements. Do you mind applying styles to your links and demonstrate using the parent & selector and nesting when you do it?

Sorry I didn't catch this till now. Everything else looks great! 🌯

[nicoskia]

Oops, I must've missed that too - it should be styled correctly now!

[egillespie]

Perfect. Thanks for the quick turn-around! :shipit: