search

nicoulaj / checksum-maven-plugin

Compute Maven project artifacts/dependencies/files checksum digests.
https://checksum-maven-plugin.nicoulaj.net
Apache License 2.0
42 stars 40 forks source link

Bump aether.version from 0.9.0.M2 to 1.1.0 #123

Closed dependabot[bot] closed 2 years ago

dependabot[bot] commented 3 years ago

Bumps aether.version from 0.9.0.M2 to 1.1.0. Updates aether-api from 0.9.0.M2 to 1.1.0

Updates aether-util from 0.9.0.M2 to 1.1.0

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
codecov[bot] commented 3 years ago

Codecov Report

Merging #123 (8de7193) into master (8f56a2c) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #123   +/-   ##
=========================================
  Coverage     77.91%   77.91%           
  Complexity      187      187           
=========================================
  Files            27       27           
  Lines           661      661           
  Branches         77       77           
=========================================
  Hits            515      515           
  Misses          113      113           
  Partials         33       33

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f56a2c...8de7193. Read the comment docs.

kwin commented 2 years ago

@nicoulaj This will make the plugin incompatible with Maven 3.1.1 as this version only exports 0.9.0.M2 (-> https://github.com/apache/maven/blob/0728685237757ffbf44136acec0402957f723d9a/pom.xml#L61). Please also rather put all dependency which are anyhow provided by the Maven distribution to "provided" scope and make sure to only reference the version which comes with the minimally supported Maven version (compare with https://issues.apache.org/jira/browse/MPLUGIN-370).

nicoulaj commented 2 years ago

I see, thanks. It did not seem to actually cause issues (https://github.com/nicoulaj/checksum-maven-plugin/actions/runs/1242353084) but I will revert it and mark it provided. I wonder what happens when a newer Maven version will be released with an incompatible APi change in aether though ?

kwin commented 2 years ago

Just updating the dependency does not break anything but using some features from the newer version might break it. In fact all those dependencies which are provided by the Maven Core class loader are not considered at all during run time