nicumicle / simple-jwt-login

This plugin allows you to log in, register, authenticate, delete and change the user password to a WordPress website using a JWT.

http://wordpress.org/plugins/simple-jwt-login/

GNU General Public License v3.0

82 stars 22 forks source link

True2thepen patch 4 #69

Closed true2thepen closed 1 year ago

true2thepen commented 1 year ago

Issue Link

21

Types of changes

[ ] Bug fix
[x] New feature

Description

Added Role Authentication Settings Tab and changed AuthenticationService to check for roles when Role Authentication is enabled.

How has this been tested?

Tested on dev server running WP 6.1.1 and PHP 8.1 using Postman.

Screenshots (optional)

Checklist:

[x] My code is tested.
[ ] I wrote tests for the impacted area
[x] I ran composer check-plugin locally

true2thepen commented 1 year ago

Closing until 3.4.9 released. Will redo once release is done.

nicumicle commented 1 year ago

I've released version 3.4.9.

@true2thepen, great job you did here :1st_place_medal:! Thank you.

Also, I would like to mention some changes to this PR. Since this role authentication refers only to authentication, I would include this view inside the auth tab, and not create a new tab. This way, it will be easier for people to find all the /auth settings in one place.

true2thepen commented 1 year ago

Will change so it is in the auth tab. Should not be a problem at all.