search

nicupavel / emlog

emlog -- the EMbedded-system LOG-device
GNU General Public License v2.0
57 stars 20 forks source link

Add support for per e-info rwlock and add more debug #8

Closed MorningLightMountain713 closed 6 years ago

MorningLightMountain713 commented 6 years ago

Good spotting! Thank you. Have added the necessary unlocks.

MorningLightMountain713 commented 6 years ago

On a side note, on my local repo I've made a change to emlog module and corresponding mkemlog to allow dynamic sizing of max_emlog_size via module_param - still defaults to 1024. For my application I have max_emlog_size set to 16384 as I was losing data when set at 1Mb. Let me know if you want a pull request. Cheers.

ahippo commented 6 years ago

Good spotting! Thank you. Have added the necessary unlocks.

Thank you so much for your work! I've just merged it.

On a side note, on my local repo I've made a change to emlog module and corresponding mkemlog to allow dynamic sizing of max_emlog_size via module_param - still defaults to 1024. For my application I have max_emlog_size set to 16384 as I was losing data when set at 1Mb. Let me know if you want a pull request. Cheers.

Oh, that's a nice feature! It'd be really cool to merge it! So, yeah, please, send a pull request in.