cron terminates on DB error after update to version 2013032201

[pavelxkrejci]

Hello, there is 1 instance of this plugin used on my server.

The update itself from Moodle admin UI went fine. However since then the cron started to crash with this debug output:

Processing module function attendanceregister_cron ...Updating AttendanceRegiste Calculating new sessions of AttendanceRegister ID 1... Found 6 Users whose AttendanceRegister Sessions need updating !!! Error writing to database !!! !! Column 'onlinesess' cannot be null INSERT INTO mdl_attendanceregister_aggregate (register,userid,onlinesess,refcourse,duration,total,grandtotal,lastsessionlogout) VALUES(?,?,?,?,?,?,?,?) [array ( 0 => '1', 1 => '46', 2 => NULL, 3 => NULL, 4 => '5485233', 5 => '0', 6 => '1', 7 => '1351849240', )] Error code: dmlwriteexception !! !! Stack trace:

• line 429 of /lib/dml/moodle_database.php: dml_write_exception thrown
• line 1107 of /lib/dml/mysqli_native_moodle_database.php: call to moodle_database->query_end()
• line 1149 of /lib/dml/mysqli_native_moodle_database.php: call to mysqli_native_moodle_database->insert_record_raw()
• line 256 of /mod/attendanceregister/locallib.php: call to mysqli_native_moodle_database->insert_record()
• line 153 of /mod/attendanceregister/locallib.php: call to attendanceregister__update_user_aggregates()
• line 473 of /mod/attendanceregister/lib.php: call to attendanceregister__build_new_user_sessions()
• line 552 of /mod/attendanceregister/lib.php: call to attendanceregister_update_user_sessions()
• line 340 of /mod/attendanceregister/lib.php: call to attendanceregister_updates_all_users_sessions()
• line 259 of /lib/cronlib.php: call to attendanceregister_cron()
• line 61 of /admin/cli/cron.php: call to cron_run() !!

[nicusX]

I'm unable to reproduce this bug. Something should have gone wrong in your installation. Apparently, in your database column mod_aggregate->onlinesess is NOT NULL, but in module schema definition (install.xml) it is nullable,

This column never changed its definition in previous versions, but it was renamed from "online" to "onlinesess" in 2013020604 version, remaining nullable. Maybe in your installation something goes wrong in that upgrade, incorrectly changing that column to NOT NULL (I don't know why, as upgrading worked in my MySQL installation).

To work around the problem I suggest to manually fix the column definition, using a SQL statement like this:

ALTER TABLE `mdl_attendanceregister_aggregate`
  MODIFY `onlinesess` tinyint(1) unsigned DEFAULT '1';