nicwatson / siegertsmiasma

0 stars 0 forks source link

The Creeping Nether only affects vanilla blocks #24

Open ramou opened 4 years ago

ramou commented 4 years ago

Creeping Nether only converts vanilla ores into nether variants, but it should probably convert everything. It leaves stuff like marble untouched. This would require a corresponding nether ore, I imagine, which may be problematic. However, in some cases, I think there were corresponding ores and it didn't use them with non-vanilla blocks, though I'm not sure I can confirm this.

While there are no nether variants for many alternate ores, there are Abyssal variants for Abyssal Nitre Ore abyssalcraft:abynitore, Abyssal Tin Ore abyssalcraft:abytinore and Abyssal Copper Ore abyssalcraft:abycopore. Technically there's also Abyssal Coralium Ore abyssalcraft:abycorore.

It also seems that amathyst is not converted into "Infernal Amethyst netherex:amathyst_ore", since I believe I mined some amethyst out inside my nether.

nicwatson commented 4 years ago

Custom rules can be made to corrupt any specified block into another. Any arbitrary block type can be chosen, but both blocks have to exist.

Corrupted ores are supposed to have "slightly higher yields," but with ores for which Creeping Nether doesn't add its own corrupted variant, there is no way to accomplish that. So instead, we're looking at three options for each block: (1) Aesthetic change. Make the ore into something that looks nethery, but isn't really any different. For instance, changing terrestrial amethyst to infernal amethyst. Only works if there is a suitable-looking block. The Abyssal ores are black rather than nethery because they're naturally found in an Abyssalcraft dimension, but they may be suitable. (2) Degradation. Turn the ore into something else entirely, like netherrack. People will lose nearby ores that way. (3) Do nothing. The block stays the way it is. Blocks that are commonly used for building, like bricks and whatnot, should probably be in this category....

Now the annoying part: every custom corruption will need to be added to the config file. This means I'll need the specific ID (and data number, if applicable) of the block to be corrupted, and ID/data of the block it should turn into.

Rather than try to consider every possible block that should be corrupted, it might make sense to add them as we go along: if someone sees something that they think should be corrupted, and has an idea of what it should turn into, then make the suggestion. It would be helpful if it's in the format: modid:beforeblock@data>modid:afterblock@data

Where @ data is the metadata number and should only be included if applicable. Example:

forestry:resource@1>abyssalcraft:copperore

would cause all Forestry copper ores to corrupt into Abyssalcraft copper ores.

The next modpack patch will include a Creeping Nether update which promises new config options and out-of-the-box Biomes O Plenty support so we'll see what that looks like too.

ramou commented 4 years ago

Excellent. If you point me at a config file so I can be easy, I may fork and issue pull requests with direct changes. I'll wait to see what's new in the offerings.

On Wed, Jan 8, 2020 at 3:30 PM nicwatson notifications@github.com wrote:

Custom rules can be made to corrupt any specified block into another. Any arbitrary block type can be chosen, but both blocks have to exist.

Corrupted ores are supposed to have "slightly higher yields," but with ores for which Creeping Nether doesn't add its own corrupted variant, there is no way to accomplish that. So instead, we're looking at three options for each block: (1) Aesthetic change. Make the ore into something that looks nethery, but isn't really any different. For instance, changing terrestrial amethyst to infernal amethyst. Only works if there is a suitable-looking block. The Abyssal ores are black rather than nethery because they're naturally found in an Abyssalcraft dimension, but they may be suitable. (2) Degradation. Turn the ore into something else entirely, like netherrack. People will lose nearby ores that way. (3) Do nothing. The block stays the way it is. Blocks that are commonly used for building, like bricks and whatnot, should probably be in this category....

Now the annoying part: every custom corruption will need to be added to the config file. This means I'll need the specific ID (and data number, if applicable) of the block to be corrupted, and ID/data of the block it should turn into.

Rather than try to consider every possible block that should be corrupted, it might make sense to add them as we go along: if someone sees something that they think should be corrupted, and has an idea of what it should turn into, then make the suggestion. It would be helpful if it's in the format: modid:beforeblock@data>modid:afterblock@data

Where @DaTa https://github.com/DaTa is the metadata number and should only be included if applicable. Example:

forestry:resource@1>abyssalcraft:copperore

would cause all Forestry copper ores to corrupt into Abyssalcraft copper ores.

The next modpack patch will include a Creeping Nether update which promises new config options and out-of-the-box Biomes O Plenty support so we'll see what that looks like too.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nicwatson/siegertsmiasma/issues/24?email_source=notifications&email_token=AAN2OQEQAHFRE4HPPT2FDGLQ4YZXRA5CNFSM4KAO6KVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIN345Q#issuecomment-572243574, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAN2OQHKIF3GEQRC2R2LSPDQ4YZXRANCNFSM4KAO6KVA .

-- Stuart Thiel, P. Eng.