nicwortel / indexfondsenvergelijken.nl

A comparison website for index funds, ETF's, banks and brokers in the Netherlands
https://www.indexfondsenvergelijken.nl/
52 stars 19 forks source link

Rework site with Astro and Vite #46

Open hugo-vrijswijk opened 7 months ago

hugo-vrijswijk commented 7 months ago

First of all, I really like this project! I wanted to learn Astro and Svelte, and this seemed like a good project to do it with 😃. I apologize for the huge diff. If you want to review it I recommend checking the PR out locally.

Reworks the application by replacing webpack with Vite, and introducing Astro and Svelte for site generation.

image
nicwortel commented 6 months ago

Wow, this is a lot of work!

I am thankful for all the effort you put into this, but I wish that you had discussed this in an issue before you did all this work. I'm not sure yet if I will merge this, because it is such a big change and introduces a number of different tools that I don't have experience with.

I will leave this PR open for now.

hugo-vrijswijk commented 6 months ago

Thanks for the reply and taking a look at this. I've tried to stick as close as possible to either industry-standard tools, or tools that are as "simple" as possible. Let me know if there's anything in here that feels like magic, I might be able to explain: