nicymike / serflings

Serflings Remake Project
https://serflings.simpleguide.net/
28 stars 0 forks source link

Bug: flag on military building far-away-from-border has a line on a map without left enemy #103

Open stepo2 opened 1 year ago

stepo2 commented 1 year ago

I have a won map without enemy and somewhere in the inner land there's suddenly two military buildings having a flag with a line, which would mean they are in reach of enemy territory. See screenshot, the two buildings left of the map. Building a new military building anywhere changes these two flags to empty ones. Maybe it's timing related, I had this game running on x64 constantly (I'm not yet sure, but I also have the suspision that on x64 speed sometimes some messages are popping up when they shouldn't, so maybe there's smething odd with these high speeds in general, like game calculation is faster/slower than graphics refreshing or something similar).

wrong_military_flags

nicymike commented 1 year ago

Thank you for the issue. I have also seen this in my own games. I guess the radius for recalculation must be wrong. Did you ever notice this in the original game? I guess I should check the original code.

stepo2 commented 1 year ago

It's like 25 or more years ago or so when I last played the original game. I have no idea. ;)

But since building a new military building anywhere building fixes the flags of the other buildings far away, it seems more like a timing issue (like that flag/distance calculation is not wrong, but instead not executed at all on some specific conditions until a new building is done).

notarocketscientist commented 1 year ago

Hi @nicymike !

I have overlooked this issue here and in the meantime I provided some savegames and a bug description of it in my own repository: https://github.com/notarocketscientist/serflings-debug/tree/master/guardhouse-flags

I also don't remember if this issue occured in the original game...

Since I discovered your awesome remake a couple of months ago I am determined to have a full playthrough of the whole campaign and I plan to document anything that seems odd in my own repo. Hope this helps to make it an even better game.

Thank you for your great work! I am really enjoying the game.

nicymike commented 1 year ago

@notarocketscientist : Thank you for the help.

Did you check out the Discord server? There is a recent discussion about the AI beeing more difficult in Serflings. I guess this is about the random numbers wich are not diversified enough. I am currently working on this. Maybe you will encounter this, too.

stepo2 commented 1 year ago

There is a recent discussion about the AI beeing more difficult in Serflings.

Can confirm. Half way through the missions (15-20 or so) it suddenly was getting unbeatable for me. But in the 1990s I won the original game without any cheats (not easily as well, but for sure the half-way missions were not so super hard as they are now).

nicymike commented 1 year ago

Can confirm. Half way through the missions (15-20 or so) it suddenly was getting unbeatable for me. But in the 1990s I won the original game without any cheats (not easily as well, but for sure the half-way missions were not so super hard as they are now).

Please try the newest development snapshot.