nidayand / node-red-contrib-tradfri

Work in progress - Node-RED node for IKEA TRÅDFRI devices
Other
24 stars 9 forks source link

Max Brightness #28

Open gjbianco opened 5 years ago

gjbianco commented 5 years ago

Currently, trying to send a brightness of 255 just causes the command to be ignored. It seems like it is known that 254 is the actual max:

https://github.com/nidayand/node-red-contrib-tradfri/issues/19#issuecomment-381088494

Either the documentation should be updated to reflect this or, better yet, clamp the brightness value being passed in. e.g. sending a brightness > 254 causes 254 to be used.

I should be able to open a PR for this hopefully sometime this week, if that would be helpful.

Edit: looks like the docs were changed last year but the change was never released?