search

nidhaloff / gpx-converter

python package for manipulating gpx files and easily converting gpx to other different formats
https://gpx-converter.readthedocs.io/en/latest/
MIT License
71 stars 18 forks source link

Added time and elevation columns to dataframe #4

Closed Riemer17 closed 3 years ago

Riemer17 commented 3 years ago

Hi, now when a gpx file has time and/or altitude data the data is saved in the dictionary, dataframe etcetera. Only when there is no time and/or altitude data the whole columns if full of None's. I don't know if this is desirable, but I haven't found a way to fix it.

nidhaloff commented 3 years ago

Hi, @Riemer17 Thanks for the issue and PR. However, I'm not quite sure if this will work as expected. Did you test this with examples that contain time and altitude values?

Riemer17 commented 3 years ago

I tested it with one example, but it might need more testing. I will do some more testing

nidhaloff commented 3 years ago

@Riemer17 can you please show the example you tested with. Sometimes the time value is added differently in some gpx files, which makes me wonder if your code will work for all different files

Riemer17 commented 3 years ago

You were right it wasn't exactly good when you looked at it. I hope I fixed it in my last commit.

I used this gpx file for example: Oefenwedstrijd_Amsterdamse_bos.zip

nidhaloff commented 3 years ago

@Riemer17 This looks better but I'm still not sure if the implementation will work for all gpx files. I will accept your PR though ;), however, I hope you can test this further and maybe check new issues that will derive from it.